solomax commented on a change in pull request #111:
URL: https://github.com/apache/openmeetings/pull/111#discussion_r487750563
##########
File path:
openmeetings-util/src/main/java/org/apache/openmeetings/util/OmFileHelper.java
##########
@@ -104,6 +104,7 @@ public static void setOmHome(File home) {
if (Strings.isEmpty(dataDir)) {
DATA_HOME = new File(OM_HOME, DATA_DIR);
} else {
+ log.info("Overwrite custom DATA_DIR: {}", dataDir);
Review comment:
> It would be better to have a central/single way of configuring, we
splitting some in XML files others in System.getProperty
`applicationContext` is for spring config only, additionally we have
1. `env.sh` for Tomcat (optional)
2. conf/server.xml for Tomcat
3. cxf-servlet.xml for REST/SOAP
4. web.xml for webapp fine tuning
5. configuration DB table for configs
6. XML files for languages
7. ......... i believe many more ............
> If you run multiple openmeetings webapps in same container you can't
configure individual params
Is it hypothetical multiple OM instances in the same Tomcat? AFAIK it was
never working solution ....
> Env variables are more for usage in shell scripts
it can be used everywhere :)
let it live in shell scripts :))
> Env variables make it hard to create unit and integration tests that run
on automated environments
Currently it is being used in unit tests ....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
