pazairfog commented on PR #863:
URL: https://github.com/apache/opennlp/pull/863#issuecomment-3370936399

   Hi,
   
   There are still some indentation errors for the French data.
   
   ```
   diff --git 
a/opennlp-core/opennlp-runtime/src/test/java/opennlp/tools/postag/POSTaggerMEIT.java
 
b/opennlp-core/opennlp-runtime/src/test/java/opennlp/tools/postag/POSTaggerMEIT.java
   index 0963f67e..3bd10889 100644
   --- 
a/opennlp-core/opennlp-runtime/src/test/java/opennlp/tools/postag/POSTaggerMEIT.java
   +++ 
b/opennlp-core/opennlp-runtime/src/test/java/opennlp/tools/postag/POSTaggerMEIT.java
   @@ -135,15 +135,15 @@ public class POSTaggerMEIT {
          Arguments.of(POLISH, 0,
            "Działacze stosowali też różne formy nacisku na polski konsulat , 
żeby zaopiekował się " +
            "bezrobotnymi z Polski albo dał im choćby na bezpłatny bilet do 
kraju .",
   -          new String[]{"NOUN", "VERB", "PART", "ADJ", "NOUN", "NOUN", 
"ADP", "ADJ", "NOUN", "PUNCT", "SCONJ", 
   -            "VERB", "PRON", "ADJ", "ADP", "PROPN", "CCONJ", "VERB", "PRON", 
"PART", "ADP", "ADJ", "NOUN", 
   +          new String[]{"NOUN", "VERB", "PART", "ADJ", "NOUN", "NOUN", 
"ADP", "ADJ", "NOUN", "PUNCT", "SCONJ",
   +            "VERB", "PRON", "ADJ", "ADP", "PROPN", "CCONJ", "VERB", "PRON", 
"PART", "ADP", "ADJ", "NOUN",
                "ADP", "NOUN", "PUNCT"}),
          // via: @kinow
          Arguments.of(CATALAN, 1,
            "Un gran embossament d'aire fred es comença a despenjar cap al 
centre d'Europa.",
              // OpenNLP, different at: idx pos 2, 3, 5, and 13(+14) -> 
however, only pos 5 is "wrong" (ref)
              new String[]{"DET", "ADJ", "NOUN", "ADP", "NOUN", "ADJ", "PRON", 
"VERB", "ADP", "VERB", "NOUN",
   -              "ADP+DET", "NOUN", "ADP", "PROPN", "PUNCT"}),
   +            "ADP+DET", "NOUN", "ADP", "PROPN", "PUNCT"}),
          // REFERENCE ("gold"):
          // "DET", "ADJ", "NOUN", "ADP", "NOUN", "ADJ", "PRON", "VERB", "ADP", 
"VERB", "NOUN", "ADP+DET",
            // "NOUN", "ADP", "PROPN", "PUNCT"})
   @@ -153,22 +153,22 @@ public class POSTaggerMEIT {
            // "NOUN", "PROPN", "PROPN", "PUNCT"
            // ok! ,  ok! ,  ??? ,  ???   ,  ok!  ,  ok! ,  ok!  ,  ok!  ,  ok! 
,  ok!  ,  ok!  ,  ok!  +  ok! ,
            // ok!  ,  ???   ,  ok!   ,  ok!
   -      // via: @meriam2303 , original by Guillaume Musso:
   -      // La jeune fille et la nuit, S.469 
   +      // via: @meriam2303, original by Guillaume Musso:
   +      // La jeune fille et la nuit, S.469
          Arguments.of(FRENCH, 0,
   -      "Vivre avec elle me faisait souffrir, mais vivre sans elle m'aurait 
tué.",
   -      new 
String[]{"VERB","ADP","PRON","PRON","AUX","VERB","PUNCT","CCONJ","VERB","ADP","PRON","PRON","AUX",
   -          "VERB","PUNCT"})
   +        "Vivre avec elle me faisait souffrir, mais vivre sans elle m'aurait 
tué.",
   +          new String[]{"VERB", "ADP", "PRON", "PRON", "AUX", "VERB", 
"PUNCT", "CCONJ", "VERB", "ADP", "PRON",
   +            "PRON", "AUX", "VERB", "PUNCT"})
          // via @meriam2303, original by Hind Choueykh Ben Salah
          // التجريد في الشّعر العربي , S. 42
          //Arguments.of(ARABIC,0,
          //"عشق أبو نواس جارية تدعى جنان",
   -      //new String[]{"VERB","PROPN","NOUN","VERB","PROPN"})  
   +      //new String[]{"VERB","PROPN","NOUN","VERB","PROPN"})
          // via @meriam2303, original by Mohamed Laarousi Elmetoui
          // التوت المر , S.7
          //Arguments.of(MARGHREBI_ARABIC_FRENCH,0,
          //"Wassa3 belek ya baba...",
   -      //new String[]{"VERB","NOUN","ITNJ","NOUN","PUNCT"})    
   +      //new String[]{"VERB","NOUN","ITNJ","NOUN","PUNCT"})
        );
      }
    }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to