mawiesne commented on code in PR #1019:
URL: https://github.com/apache/opennlp/pull/1019#discussion_r3098353441


##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/util/XmlUtil.java:
##########
@@ -65,8 +65,13 @@ public static DocumentBuilder createDocumentBuilder() {
    */
   public static SAXParser createSaxParser() {

Review Comment:
   There are further recommended features. Can we modify/enhance the config as 
described here:
   
   https://stackoverflow.com/a/59736162 ?
   



##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/util/XmlUtil.java:
##########
@@ -65,8 +65,13 @@ public static DocumentBuilder createDocumentBuilder() {
    */
   public static SAXParser createSaxParser() {

Review Comment:
   Further reference:
   
   
https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to