rzo1 commented on PR #1111: URL: https://github.com/apache/opennlp/pull/1111#issuecomment-4799034381
- `Builder.dashes()` is plural while every other layer-enable method is singular (`nfc`, `whitespace`, `caseFold`, `accentFold`) and the enum constant is `DASH`. Suggest `dash()` for consistency. - Class javadoc `@links NormalizationProfile#searchAnalyzer()`, introduced only in #1112 - dangling link until that lands. - `analyze(CharSequence)` on a `lemmatize()`-configured analyzer throws at `Term` construction (eager LEMMA, null posTag), which reads against the javadoc phrasing that LEMMA "is not available from them." Either clarify the doc or skip unsatisfiable eager layers. Currently untested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
