krickert commented on PR #1111: URL: https://github.com/apache/opennlp/pull/1111#issuecomment-4892048211
@mawiesne Addressed in 52807383. - Replaced `Objects.requireNonNull` with `IllegalArgumentException` across the `TermAnalyzer` public methods, the `Builder` setters, and `Term` (`at`, constructor); `@throws` javadoc updated. The two sites not in your list (`caseFold(Locale)`, `accentFold`) are swept too so the class is uniform. - Gave `builder()` a specific javadoc. - Added `TermTest` for `Term`'s public API (original/normalized/span/at/peel). - Added `TermAnalyzerMultilingualTest`: German umlauts, Romance accents, Cyrillic case folding, Japanese NFC/NFKC. - Flipped the existing null-argument tests to `IllegalArgumentException`. Rebased onto current main; runtime module green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
