On Jun 14, 2013 11:45 PM, "Ariel Constenla-Haile" <[email protected]> wrote: > > Hi Jan, > > On Fri, Jun 14, 2013 at 02:40:23PM +0200, janI wrote: > > The change comes from me, after a discussion on the dev list and was > > applied as agreed. > > IIRC you asked about x-comment, not about x-no-translate (this one is > the root of the build breaker).
not thst it shall be a long discussion,:-) but I did ask for quite a number of changes, like removing non en-us entries, cleaning duplicate en-us text entries and a couple of x- problems. > > > BUT never the less, since it is a build breaker, it needs to be reverted. > > There is no need to the revert the whole commit, only two files, see > https://issues.apache.org/ooo/show_bug.cgi?id=122518 and the attachments > there. only reverting 2 files is a lot easier, thx for the advice. > > Keeping comments and splitting long lines may be an enhancement (see > https://issues.apache.org/ooo/show_bug.cgi?id=122518#c9 ) but there is > no need to revert that. > > And the error with CaptionOrderNumberingFirst > https://issues.apache.org/ooo/show_bug.cgi?id=122518#c10 comes from the > original commit that forgot to mark this as x-no-translate (this flags > the string as not-extractable by localize so that it does not appear in > the sdf file, nor is merged back) > http://hg.services.openoffice.org/OOO340/rev/ca60b76cc688 > > > Ps. the commit is old, so at least it underlines my request from earlier > > that we regulary build languages in buildbot. > > I do build with --with-lang="en-US es" and the bug didn't show up > until the translation was integrated (rev. 1489712 from June 5th). > Building languages in the buildbot is a nonsense if there is no > periodical integration of localization. I agree with you, but I have the opinion that localization should be integrated just as frequently as source changes. My target with l10n is still that pootle changes moves automatically to svn (maybe with a delay of a day). If we dont build with-lang regulary we dont see if e.g. rejuvenate01 changes breaks in a language build, so its not only the translated text that makes a difference. rgds jan i > > > Regards > -- > Ariel Constenla-Haile > La Plata, Argentina
