Armin Le Grand <armin.le.gr...@me.com> has asked j...@apache.org for 4.0.0_release_blocker: Bug 122676: undo-redo works correctly only after double click https://issues.apache.org/ooo/show_bug.cgi?id=122676
------- Additional Comments from Armin Le Grand <armin.le.gr...@me.com> ALG: Using the SfxDispatcher::Execute call which allows a null-terminated list of SfxPoolItems to be handed over instead of doing two calls with just one SfxPoolItem. The difference is that only one SlotID can be handed over, Checked that the adding of SfxPoolItems to an SfxItemSet is directly done in SfxDispatcher::Execute itself, thus the SfxPoolItems always arrive at the application as SfxItemSet. Prerequisite to make this work is that the SlotIDs used lead to the correct execution, this is done in DrawViewShell::FuTemporary and in a single case the slots SID_ATTR_FILL_STYLE, SID_ATTR_FILL_COLOR, SID_ATTR_FILL_GRADIENT, SID_ATTR_FILL_HATCH and SID_ATTR_FILL_BITMAP are handled using SetAttributes at the SdrDrawView. Thus, using a single Execute call with two SfxPoolItems and the slot of the original command and not SID_ATTR_FILL_STYLE works well. This path exists in the other apps, too, so I would say the change is safe. Resetting the ReleaseBlocker flag now with a possible solution which I evaluate as not dangerous. Preparing to add the patch, too. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
