On 14 Nov, Peter Kovacs wrote:
> Hi all,
> 
> I am proudly did finish a build tonight.
> 
> However I did2 additional Code changes. I do not trust my choice. :P
> 
> Both changes targetet to make the compiler happy, and to make a best 
> shot correctness.
> 
> But I do not understand what I changed, I probably did it wrong. :-D
> 
> 
> 1) packagepixeliterator.hxx line 611
> 
> Error:
> 
> const int remainder( x(d.x) % num_intraword_positions );
> 
> Explanaition: x is an int while d.x is also int because d is a 
> vigra:Diff2D. The compiler wants to caculate something but interprets x 
> as a functioncall thus fails.

I wonder how this ever worked ... maybe this code is never used so
older compilers ignored it.

> Fix:
> 
> I gave the compiler a valid formula. I thought maybe t is a dif and we 
> want to move. I decided at random for negative move. Probable positive 
> (+) would be more wise. Now that I think of it.
> 
> But I realy dont know f it is the right way.
> 
> const int remainder( (x-d.x) % num_intraword_positions );

Based on the similar set( value_type v, difference_type const & d )
code further down, it looks like + should be used instead of -.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Reply via email to