Thank you :). What "success code"? Which multiple implementations?
On Fri, Nov 17, 2017 at 4:41 PM, Peter kovacs <pe...@apache.org> wrote: > Awesome thanks Damjan! > > Would it make sense to route the success code through the connectivity > code for the future? > > I would rather like to have one time implementation instead of maintain > redundant implementations. > ( the drawback is that bugs have bigger impact. Ofc) > > > Am 17. November 2017 15:26:57 MEZ schrieb Damjan Jovanovic < > dam...@apache.org>: > >Hi > > > >I am familiar with the database driver code in main/connectivity, but > >much > >less familiar with the Base code main/dbaccess where the problem is. > > > >On an unrelated past bug in my code in a main/connectivity driver, I > >did > >however briefly encounter that same problem where clicking "Create > >table" > >does nothing. Debugging it proved very difficult. Far too commonly, > >Base > >catches and silently swallows exceptions via the likes of: > > > >catch (Exception&) {} > > > >which explains why no error is reported to the user, and means that > >even if > >you put a breakpoint on such a line, you can't see anything about the > >exception as there is no variable it's assigned to: not the exception's > >particular subtype, not its message, and in the abomination that is C++ > >generally, never the most useful part: its stack trace. > > > >I then tried doing "catch throw" in gdb to try examine the exception > >when > >it's thrown instead of caught, however that took me on a wild goose > >chase, > >as multiple harmless exceptions get thrown during the course of that > >dialog > >opening. > > > >Eventually I gave up and fixed the bug in my main/connectivity driver. > >I > >can't remember which bug; probably that null strings were being > >returned > >from Java to UNO, and UNO strings can't ever be null (even in AOO's > >C++, > >the infamous OUString is always empty, never null). > > > >Later I can try to find and send you the beginning of that path through > >the > >Base code that's involved in opening the "Create table" dialog, so you > >have > >somewhere to start from. Since I don't have a Mac or access to one, I > >can't > >help debug this directly. But feel free to ask me any questions. > > > >Regards > >Damjan > > > > > >On Thu, Nov 16, 2017 at 10:12 PM, Dave Fisher <dave2w...@comcast.net> > >wrote: > > > >> Hi Damjan, > >> > >> Do you have any tips or pointers regarding the Base issue we are > >having > >> with Builds on MacOS? > >> > >> I’m seeing your comments on https://bz.apache.org/ooo/ > >> show_bug.cgi?id=126655 and can’t help but wonder if the code is > >fragile > >> here. If nothing else some help tracing the code could help. > >> > >> Does the Redland configuration and the update in trunk help us here? > >> > >> Regards, > >> Dave > >> > >> > On Nov 16, 2017, at 10:40 AM, Jim Jagielski <j...@jagunet.com> > >wrote: > >> > > >> > OK, I am pretty much almost out of ideas. I've created a VM which > >is > >> > almost an exact match for what I could determine was the build > >> > environ for 4.1.2. Attached is a patch file that shows the diffs > >between > >> > the config.out for 4.1.2 and my build of 4.1.2. My build doesn't > >suffer > >> > from the corrupted diagram but it DOES still suffer from the > >> table/Database > >> > regression. AFAIK, the official 4.1.2 build suffers from neither. > >> > > >> > So what is causing this weird behavior I simply don't know... As > >> > one can see, there's nothing, at least as reported by config.log, > >which > >> is > >> > different and this is straight from > >> > > >> > https://svn.apache.org/repos/asf/openoffice/tags/AOO412 > >> > > >> > <build-config-log-diffs.txt> > >> > > >--------------------------------------------------------------------- > >> > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > >> > For additional commands, e-mail: dev-h...@openoffice.apache.org > >> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >