Hi Jim,

Great!

One additional thought:

We use $Revision$ in main/solenv/bin/build.pl and a lot of other files.
That doesn't seem to work anymore since we switched from SVN to Git.

We have AC_REVISION( $Revision$ ) in configure.ac. Maybe we can replace
the logic [1].

Regards,

   Matthias

[1]
https://stackoverflow.com/questions/8215785/how-can-i-use-ac-revision-with-git/8216176


Am 30.09.19 um 19:14 schrieb Jim Jagielski:
> I have an idea on how to include the git hash on the source distro... will 
> try to work on it this week.
>
>> On Sep 26, 2019, at 7:58 PM, Don Lewis <truck...@apache.org> wrote:
>>
>> On 26 Sep, Matthias Seidel wrote:
>>> Hi Don,
>>>
>>> Am 20.09.19 um 06:47 schrieb Don Lewis:
>>>> Prioritizing the publication of the source tarball would be helpful.  I
>>>> can't publish the updated FreeBSD port until that happens, and the
>>>> binary packages won't be available until a couple days after that.
>>> How was it done in the past?
>> Basically it wasn't done and nobody noticed.  Pretty anyone who might
>> notice was building from an svn checkout and not a source tarball.
>> Probably the biggest consumer of the source tarball was the FreeBSD
>> port, which I maintain, and I never notice that the revision info was
>> blank on FreeBSD.  I only noticed when the discussion came up where
>> during the cutover to git.
>>
>>> As I understand it, the revision was also missing when building from
>>> source tarball in earlier versions?
>> Yes.  Building from a source tarball is probably something we should
>> test on an ongoing basis.
>>
>>> We should implement it in trunk now and backport it to AOO42X and AOO418.
>> Agreed.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
>> For additional commands, e-mail: dev-h...@openoffice.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
> For additional commands, e-mail: dev-h...@openoffice.apache.org
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to