ardovm commented on pull request #89:
URL: https://github.com/apache/openoffice/pull/89#issuecomment-652464308


   I see that in the same file there are other fixed-size arrays used as stacks 
(if I understand correctly):
   * `CffSubsetterContext::mnValStack`,
   * `CffSubsetterContext::mnHintStack`.
   
   If it is of any interest to turn also them into `std::vector` or other 
containers, please let me know, and I could include them into this PR.
   
   Please be aware that this is my first PR against OpenOffice; if there are 
any tests I can run to validate these changes, kindly give me some pointers. By 
now, I just built the source and tried to reproduce the crash originating [bug 
12359](https://bz.apache.org/ooo/show_bug.cgi?id=125359).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Reply via email to