How about we change the Linux and FreeBSD Code to the C++ static cast?

I think we should move away from C Code and only use it where we must use it.

On 02.12.20 04:30, Jim Jagielski wrote:


On Dec 1, 2020, at 6:16 PM, Don Lewis <truck...@apache.org> wrote:

On  1 Dec, j...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.

jim pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/openoffice.git


The following commit(s) were added to refs/heads/trunk by this push:
     new d73dd1d  Huge updates to macOS UNO bridges, based on FreeBSD and Linux.
d73dd1d is described below

commit d73dd1d32e12ca3b96b7bbfff854b742992ff915
Author: Jim Jagielski <jim...@gmail.com>
AuthorDate: Tue Dec 1 16:59:54 2020 -0500

    Huge updates to macOS UNO bridges, based on FreeBSD and Linux.

diff --git a/main/bridges/source/cpp_uno/gcc3_freebsd_x86-64/except.cxx 
b/main/bridges/source/cpp_uno/gcc3_freebsd_x86-64/except.cxx
index 7902bd9..bfe18db 100644
--- a/main/bridges/source/cpp_uno/gcc3_freebsd_x86-64/except.cxx
+++ b/main/bridges/source/cpp_uno/gcc3_freebsd_x86-64/except.cxx
@@ -187,7 +187,7 @@ type_info * RTTI::getRTTI( typelib_CompoundTypeDescription 
*pTypeDescr ) SAL_THR
                     type_info * base_rtti = getRTTI(
                         (typelib_CompoundTypeDescription 
*)pTypeDescr->pBaseTypeDescription );
                     rtti = new __si_class_type_info(
-                        strdup( rttiName ), static_cast<__class_type_info 
*>(base_rtti) );
+                        strdup( rttiName ), (__class_type_info *)base_rtti );
                 }
                 else
                 {
What is the reason for this change?  static_cast is the more correct C++
way as opposed to a C-style cast.

Part of a merge from the code in the FreeBSD and Linux files...
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Reply via email to