Thanks for sharing your software.

Looking through the source I noticed some code smells like creating XML
as strings instead of using lxml and not quoting variables used in SQL.
flake8 also reports several issues with convert2osm.py.

One also wonders how this compares to ogr2osm which can be used for the
same purpose. Have you tried using that before deciding to write this?

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1

_______________________________________________
dev mailing list
dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/dev

Reply via email to