OK, it passes now that I pushed that commit:
commit 72f7976600581cc9c57915dad150f7984c33e18b
Author: Ben Pfaff <[email protected]>
Date: Fri Aug 12 14:59:11 2011 -0700
ofp-parse: Fix parsing of register values 2**31 and greater.
Reported-by: Ethan Jackson <[email protected]>
On Fri, Aug 12, 2011 at 01:48:51PM -0700, Ethan Jackson wrote:
> I'm able to reproduce it now. It doesn't work with -m32 and does with
> -m64, I'll figure out whats wrong and fix it before merging, probably
> something minor.
>
> Ethan
>
> On Fri, Aug 12, 2011 at 13:45, Ben Pfaff <[email protected]> wrote:
> > I used the latest version of your series. ?I'm running 32-bit userspace
> > (2.6.32-5-686-bigmem).
> >
> > So you can compare what I tested against what you have, I pushed what I
> > tested to a branch called "review" on openvswitch.org. ?(I'll delete it
> > when we're done.)
> >
> > On Fri, Aug 12, 2011 at 12:40:44PM -0700, Ethan Jackson wrote:
> >> Yep it passes for me. ?Very strange. ?Is this based on the latest
> >> version of the series I sent out? ?Are you running 32bit or 64 bit
> >> user space? ?I wonder if it has something to do with that?
> >>
> >> Ethan
> >>
> >> On Fri, Aug 12, 2011 at 12:02, Ben Pfaff <[email protected]> wrote:
> >> > I applied patches 1-5 to the current "master" and get the following test
> >> > failure from the new test. ?Does it pass for you?
> >> >
> >> > ## ------------------------------ ##
> >> > ## openvswitch 1.2.90 test suite. ##
> >> > ## ------------------------------ ##
> >> > 379. ofproto-dpif.at:21: testing ofproto-dpif - registers ...
> >> > ../../tests/ofproto-dpif.at:22: test-openflowd --detach --pidfile
> >> > --enable-dummy --log-file --fail=closed dummy@br0 none
> >> > --datapath-id=fedcba9876543210
> >> > stderr:
> >> > Aug 12 12:01:50|00001|vlog|INFO|opened log file
> >> > /home/blp/nicira/openflow/_build/tests/testsuite.dir/379/test-openflowd.log
> >> > Aug 12 12:01:50|00002|openflowd|INFO|Open vSwitch version 1.2.90
> >> > Aug 12 12:01:50|00003|openflowd|INFO|OpenFlow protocol version 0x01
> >> > Aug 12 12:01:50|00004|ofproto|INFO|using datapath ID 000000232089e6a8
> >> > Aug 12 12:01:50|00005|ofproto|INFO|datapath ID changed to
> >> > fedcba9876543210
> >> > ../../tests/ofproto-dpif.at:22: sed < stderr '
> >> > /vlog|INFO|opened log file/d
> >> > /openflowd|INFO|Open vSwitch version/d
> >> > /openflowd|INFO|OpenFlow protocol version/d
> >> > /ofproto|INFO|using datapath ID/d
> >> > /ofproto|INFO|datapath ID changed to fedcba9876543210/d'
> >> > ../../tests/ofproto-dpif.at:38: ovs-ofctl add-flows br0 flows.txt
> >> > ../../tests/ofproto-dpif.at:39: ovs-appctl -t test-openflowd
> >> > ofproto/trace br0
> >> > 'in_port(90),eth(src=50:54:00:00:00:05,dst=50:54:00:00:00:07),eth_type(0x0800),ipv4(src=192.168.0.1,dst=192.168.0.2,proto=1,tos=0),icmp(type=8,code=0)'
> >> > stdout:
> >> > Flow: tunnel0:in_port005a:tci(0) mac50:54:00:00:00:05->50:54:00:00:00:07
> >> > type0800 proto1 tos0 ip192.168.0.1->192.168.0.2 port8->0
> >> > Rule: table=0 cookie=0 in_port=90
> >> > OpenFlow actions=resubmit:2,resubmit:3,resubmit:4,resubmit:91
> >> >
> >> > ? ? ? ?Resubmitted flow: unchanged
> >> > ? ? ? ?Rule: table=0 cookie=0 in_port=2
> >> > ? ? ? ?OpenFlow actions=load:0xdb000->NXM_NX_REG0[]
> >> >
> >> > ? ? ? ?Resubmitted flow: tunnel0:in_port005a:tci(0)
> >> > mac50:54:00:00:00:05->50:54:00:00:00:07 type0800 proto1 tos0
> >> > ip192.168.0.1->192.168.0.2 port8->0
> >> > ? ? ? ?Rule: table=0 cookie=0 in_port=3
> >> > ? ? ? ?OpenFlow actions=load:0xdea->NXM_NX_REG0[20..31]
> >> >
> >> > ? ? ? ?Resubmitted flow: tunnel0:in_port005a:tci(0)
> >> > mac50:54:00:00:00:05->50:54:00:00:00:07 type0800 proto1 tos0
> >> > ip192.168.0.1->192.168.0.2 port8->0
> >> > ? ? ? ?Rule: table=0 cookie=0 in_port=4
> >> > ? ? ? ?OpenFlow actions=load:0xeef->NXM_NX_REG0[0..11]
> >> >
> >> > ? ? ? ?Resubmitted flow: tunnel0:in_port005a:tci(0)
> >> > mac50:54:00:00:00:05->50:54:00:00:00:07 type0800 proto1 tos0
> >> > ip192.168.0.1->192.168.0.2 port8->0
> >> > ? ? ? ?Rule: table=0 cookie=0 in_port=91
> >> > ? ? ? ?OpenFlow actions=resubmit:5,resubmit:6,resubmit:7,resubmit:92
> >> >
> >> > ? ? ? ? ? ? ? ?Resubmitted flow: unchanged
> >> > ? ? ? ? ? ? ? ?Rule: table=0 cookie=0 in_port=5
> >> > ? ? ? ? ? ? ? ?OpenFlow actions=move:NXM_NX_REG0[]->NXM_NX_REG1[]
> >> >
> >> > ? ? ? ? ? ? ? ?Resubmitted flow: tunnel0:in_port005a:tci(0)
> >> > mac50:54:00:00:00:05->50:54:00:00:00:07 type0800 proto1 tos0
> >> > ip192.168.0.1->192.168.0.2 port8->0
> >> > ? ? ? ? ? ? ? ?Rule: table=0 cookie=0 in_port=6
> >> > ? ? ? ? ? ? ? ?OpenFlow actions=load:0x22222222->NXM_NX_REG2[]
> >> >
> >> > ? ? ? ? ? ? ? ?Resubmitted flow: tunnel0:in_port005a:tci(0)
> >> > mac50:54:00:00:00:05->50:54:00:00:00:07 type0800 proto1 tos0
> >> > ip192.168.0.1->192.168.0.2 port8->0
> >> > ? ? ? ? ? ? ? ?Rule: table=0 cookie=0 in_port=7
> >> > ? ? ? ? ? ? ? ?OpenFlow
> >> > actions=move:NXM_NX_REG1[20..31]->NXM_NX_REG2[0..11]
> >> >
> >> > ? ? ? ? ? ? ? ?Resubmitted flow: tunnel0:in_port005a:tci(0)
> >> > mac50:54:00:00:00:05->50:54:00:00:00:07 type0800 proto1 tos0
> >> > ip192.168.0.1->192.168.0.2 port8->0
> >> > ? ? ? ? ? ? ? ?Rule: table=0 cookie=0 in_port=92
> >> > ? ? ? ? ? ? ? ?OpenFlow
> >> > actions=resubmit:8,resubmit:9,resubmit:10,resubmit:11
> >> >
> >> > ? ? ? ? ? ? ? ? ? ? ? ?Resubmitted flow: unchanged
> >> > ? ? ? ? ? ? ? ? ? ? ? ?Rule: table=0 cookie=0 in_port=8
> >> > ? ? ? ? ? ? ? ? ? ? ? ?OpenFlow
> >> > actions=move:NXM_NX_REG1[0..11]->NXM_NX_REG2[20..31]
> >> >
> >> > ? ? ? ? ? ? ? ? ? ? ? ?Resubmitted flow: tunnel0:in_port005a:tci(0)
> >> > mac50:54:00:00:00:05->50:54:00:00:00:07 type0800 proto1 tos0
> >> > ip192.168.0.1->192.168.0.2 port8->0
> >> > ? ? ? ? ? ? ? ? ? ? ? ?No match
> >> >
> >> > ? ? ? ? ? ? ? ? ? ? ? ?Resubmitted flow: unchanged
> >> > ? ? ? ? ? ? ? ? ? ? ? ?No match
> >> >
> >> > ? ? ? ? ? ? ? ? ? ? ? ?Resubmitted flow: unchanged
> >> > ? ? ? ? ? ? ? ? ? ? ? ?No match
> >> >
> >> > Final flow: unchanged
> >> > Datapath actions: drop
> >> > ../../tests/ofproto-dpif.at:40: tail -1 stdout
> >> > --- - ? 2011-08-12 12:01:50.295483796 -0700
> >> > +++
> >> > /home/blp/nicira/openflow/_build/tests/testsuite.dir/at-groups/379/stdout
> >> > ? 2011-08-12 12:01:50.000000000 -0700
> >> > @@ -1,2 +1,2 @@
> >> > -Datapath actions: 20,21,22
> >> > +Datapath actions: drop
> >> >
> >> > test-openflowd.log:
> >> >> Aug 12 12:01:50|00001|vlog|INFO|opened log file
> >> >> /home/blp/nicira/openflow/_build/tests/testsuite.dir/379/test-openflowd.log
> >> >> Aug 12 12:01:50|00002|openflowd|INFO|Open vSwitch version 1.2.90
> >> >> Aug 12 12:01:50|00003|openflowd|INFO|OpenFlow protocol version 0x01
> >> >> Aug 12 12:01:50|00004|ofproto|INFO|using datapath ID 000000232089e6a8
> >> >> Aug 12 12:01:50|00005|ofproto|INFO|datapath ID changed to
> >> >> fedcba9876543210
> >> > 379. ofproto-dpif.at:21: ?FAILED (ofproto-dpif.at:40)
> >> >
> >> > ## ------------- ##
> >> > ## Test results. ##
> >> > ## ------------- ##
> >> >
> >> > ## -------------------------- ##
> >> > ## testsuite.log was created. ##
> >> > ## -------------------------- ##
> >> >
> >> > Please send per-test log files and all information you think might help:
> >> >
> >> > ? To: <[email protected]>
> >> > ? Subject: [openvswitch 1.2.90] testsuite: 379 failed
> >> >
> >> > You may investigate any problem if you feel able to do so, in which
> >> > case the test suite provides a good starting point. ?Its output may
> >> > be found below `tests/testsuite.dir'.
> >> >
> >> >
> >
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
