I've been meaning to do something like for a while. Thanks! On 01/13/15 at 05:28pm, Andy Zhou wrote: > +# Kernel module testing > +check-kmod: all tests/atconfig tests/atlocal $(KMOD_TESTSUITE) > + $(MAKE) modules_install > + $(SHELL) '$(KMOD_TESTSUITE)' -C tests AUTOTEST_PATH='$(AUTOTEST_PATH)' > -d $(TESTSUITEFLAGS) > +
It would be great to allow the testsuite to be run both for the datapath/ module but also against a standard kernel. So maybe add "check-kernel" target which skips the modules_install? > +m4_define([OVS_KMOD_VSWITCHD_START], > + [ AT_CHECK([modprobe openvswitch]) Assuming that we want to use this outside of Vagrant as well: I wonder whether we should provide a config with -C ensuring that the freshly compiled kmod is actually loaded. We might also want to verify if a openvswitch kmod is already loaded. > +# ADD_VETH([port], [namespace], [ovs-br], [ip_addr], [netmask]) > +# > +# Add a pair of veth ports. 'port' will be added to name space 'namespace', > +# and "ovs-'port'" will be added to ovs bridge 'ovs-br'. > +# > +# The 'port' in 'namespace' will be brought up with static IP address > +# with 'ip_addr' and 'netmask'. > +# > +# The existing 'port' or 'ovs-port' will be removed before new ones are > added. > +# > +m4_define([ADD_VETH], > + [ ovs-vsctl del-port $3 ovs-$1 > + ip netns exec $2 ip link del $1 > + AT_CHECK([ ip link add $1 type veth peer name ovs-$1 ]) > + AT_CHECK([ ip link set $1 netns $2 ]) > + AT_CHECK([ ovs-vsctl add-port $3 ovs-$1 ]) > + AT_CHECK([ ip link set dev ovs-$1 up ]) > + AT_CHECK([ ip netns exec $2 ifconfig $1 $4 netmask $5 up ]) Let's be consistent and use ip addr add ;-) _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
