On Wed, Jul 15, 2015 at 1:33 PM, Russell Bryant <rbry...@redhat.com> wrote:
> On 07/15/2015 03:15 PM, Russell Bryant wrote: > > On 07/15/2015 03:09 PM, Alex Wang wrote: > >> Also, what do you think about my proposal for using "type" and > "options" > >> fields on logical ports in OVN_Northbound instead of a special port > >> name? If we went this route, you don't need "logical_switches" to > be a > >> smap, it can just be a list of logical switch names. Creating a > >> connection in OVN northbound would be something like: > >> > >> Logical_Port > >> name: <anything> > >> type: vtep > >> options: > >> vtep_physical_switch: <...> > >> vtep_logical_switch: <...> > >> > >> > >> > >> One thing I see missing is that: multiple vtep physical switches > >> (supported by the same vtep db) could connect to the same vtep > >> logical switch... In that case, logical switch name can no longer > >> uniquely identify a connection of 'a vtep physical switch to a vtep > >> logical switch'... That's why I use the combination of > >> pswitch_name+lswitch_name. > >> > >> With you suggestion, first, the logical port name in ovn-nb can be > >> duplicated. And if that is allowed, we need to pass the "options" > >> down to ovn-sb Binding table to uniquely binding the vtep lport to > >> vtep chassis. > > > > Yes, I was thinking that this information would have to be added to the > > Binding table in OVN_Southbound as well so that you still have the > > pswitch+lswitch info, just in a little bit more structured way. > > > > Also, I've got some patches in progress that implements this. It's a > part of a series I'm working on, but I could split it out separately if > you think it makes sense and want to rebase on them. > > Hey Russell, I'd like to see and try out your change. At the same time, I do want to have my vtep controller code reviewed. I think I'll first adopt your suggestion and rename the column to "vtep_logical_switches" and repost the series to have it reviewed. With you change, I think I only need to change the binding module a bit to adopt the new naming format. The main logic (especially what is in pipeline module) will remain intact~ ;D Thanks, Alex Wang, > -- > Russell Bryant > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev