Make sense to me. I will update the patch. Thanks, Ryan. - Hui
On Mon, Jul 18, 2016 at 10:37 AM, Ryan Moats <[email protected]> wrote: > "dev" <[email protected]> wrote on 07/02/2016 12:25:11 PM: > >> From: Ben Pfaff <[email protected]> >> To: Justin Pettit <[email protected]> >> Cc: [email protected], Hui Kang <[email protected]> >> Date: 07/02/2016 12:25 PM >> Subject: Re: [ovs-dev] [PATCH] [OVN-northd] Rename nbs/nbr to nbsp/nbrp >> Sent by: "dev" <[email protected]> > > >> >> On Fri, Jun 24, 2016 at 12:39:54PM -0400, Hui Kang wrote: >> > These variables indicate ports in nb switches or routers. >> > >> > Signed-off-by: Hui Kang <[email protected]> >> >> Justin, do you want to review this? You like naming. > > I'll throw my $0.02 onto the table (and yes, it's only barely > worth $0.02) - if we are going to rename them, how about we > change them to nlsp and nlrp so that they align with the > structs that they are holding pointers to. > > Ryan > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
