Fair point, I guess this looks more like a bug fix than a new features. After discussing offline with Ben and having another set of eyes on the changes I backported this to branch-2.5.
Thanks, Daniele On 25/07/2016 02:29, "Loftus, Ciara" <ciara.lof...@intel.com> wrote: >> >> Thanks Flavio for checking and Daniel for your consideration. >> Indeed the issue exists in 2.5 branch. >> >> We are treating this more in the bucket of a performance bug fix than a >> feature. >> >> Any specific testing that you would like to see run to help reduce >> your concern related to changes to the core modules ? >> >> Ciara, what's your opinion on these changes for a backport ? > >I'm of the same opinion as yourself and Flavio that this is more a fix than a >feature. I'd like to see it backported. >But I understand there may be some risk associated with due to the nature of >the changes. > >Thanks, >Ciara > >> >> Thanks >> Vinod >> >> >> >> -----Original Message----- >> From: Daniele Di Proietto [mailto:diproiet...@vmware.com] >> Sent: Friday, July 22, 2016 3:49 PM >> To: Flavio Leitner <f...@redhat.com>; Vinod, Chegu >> <chegu_vi...@hpe.com> >> Cc: kris...@redhat.com; ovs-dev <dev@openvswitch.org>; Loftus, Ciara >> <ciara.lof...@intel.com> >> Subject: Re: Backport Request: dpif-netdev: Remove PMD latency on >> seq_mutex >> >> I'm not sure I'm 100% comfortable back porting this to branch-2.5 >> >> I see the change more as a feature rather than a bugfix. >> >> Also it touches some core modules (seq and rcu) in a non trivial way. >> >> >> What do you guys think? >> >> Thanks, >> >> Daniele >> >> On 22/07/2016 15:03, "Flavio Leitner" <f...@redhat.com> wrote: >> >> >(adding ovs-dev mailing list and more people interesting on the >> >backport to CC) >> > >> >On Mon, Jul 18, 2016 at 05:31:52AM +0000, Vinod, Chegu wrote: >> >> Hi Flavio, Karl, >> >> >> >> Is there a version of the following fix available that is compatible with >> >> OVS >> 2.5? >> >> >> >> >> https://github.com/openvswitch/ovs/commit/9dede5cff553d7c4e074f04c52 >> 5 >> >> c1417eb209363 >> >> >> >> If yes can it backported to the 2.5 branch ? >> > >> >branch-2.5 is affected by the same issue. I tested the patch from >> >branch master (cherry-pick) and it solved the issue. >> > >> >Daniele, >> > >> >What do you think? If you agree, do you need me to post the backported >> >patch or is it enough for you to cherry-pick? >> > >> >Thanks, >> >-- >> >fbl > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
