On Tue, Aug 9, 2016 at 8:55 PM, Zong Kai LI <zealo...@gmail.com> wrote: > > This patch renames table Address_Set to Set, Address_Set.addresses to > Set.members to reflect a more broad purpose, that we can define other types > of sets than address set. > > Per discussion around [1] and [2], this patch only does rename work on table > Address_Set, and consider put future purpose on using table Set, to create > port set which will be used to improve and skinny ACLs, in following pacthes. > > Since it only renames table Address_Set, and up to now, only address set get > supported, so this patch doesn't rename variables and methods which used for > address set, such as [3]. > > [1] http://openvswitch.org/pipermail/dev/2016-August/077121.html > [2] http://openvswitch.org/pipermail/dev/2016-August/077224.html > [3] > https://github.com/openvswitch/ovs/blob/master/ovn/controller/lflow.c#L41-L42 > https://github.com/openvswitch/ovs/blob/master/ovn/controller/lflow.c#L62-L205 > Hi Zongkai,
The port set is a great idea! But do we really need to rename the Address_Set table? Can we just have 2 tables: Address_Set and Port_Set (and we can add more in the future if needed)? If we really want to put them in the same table, then a new column "type" is needed here, right? Thanks, Han _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
