On Tue, Aug 9, 2016 at 11:55 PM, Zong Kai LI <zealo...@gmail.com> wrote:
> This patch renames table Address_Set to Set, Address_Set.addresses to > Set.members to reflect a more broad purpose, that we can define other > types > of sets than address set. > > Per discussion around [1] and [2], this patch only does rename work on > table > Address_Set, and consider put future purpose on using table Set, to create > port set which will be used to improve and skinny ACLs, in following > pacthes. > > Since it only renames table Address_Set, and up to now, only address set > get > supported, so this patch doesn't rename variables and methods which used > for > address set, such as [3]. > > [1] http://openvswitch.org/pipermail/dev/2016-August/077121.html > [2] http://openvswitch.org/pipermail/dev/2016-August/077224.html > [3] > https://github.com/openvswitch/ovs/blob/master/ > ovn/controller/lflow.c#L41-L42 > https://github.com/openvswitch/ovs/blob/master/ovn/controller/lflow.c#L62- > L205 > > Signed-off-by: Zong Kai LI <zealo...@gmail.com> > --- > I brought this patch up for discussion in today's OVN IRC meeting. Ben raised a good point: <blp> russellb: I have questions whether port sets and address sets are really the same kind of beast though. For port sets, possibly we want to manage them via references to rows as opposed to sets of strings. I think that's a great point, so let's just defer the rename and we'll go through deciding on a final approach for this after 2.6. -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
