rmannibucau commented on a change in pull request #28: URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439844794
########## File path: webbeans-junit5/src/test/java/org/apache/openwebbeans/junit5/parameter/ParameterResolutionTest.java ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.openwebbeans.junit5.parameter; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +import org.apache.openwebbeans.junit5.Cdi; +import org.apache.openwebbeans.junit5.bean.MyService; +import org.junit.jupiter.api.Test; + +@Cdi(classes = MyService.class) +class ParameterResolutionTest +{ + @Test Review comment: Hmm, yes and no. It enables users to handle themselves the exclusions of parameters without @DontInject which is good when the extension resolves the parameter in CDI context but with additional rules (like adding an implicit qualifier or having a type mapping). Since we have a DoneInject test, it is ok to drop but I would keep it as a doc example, can simplify things in some rare cases for "application junit extensions" - extension you write in final apps, not as a reusable extension/lib. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
