dongjoon-hyun commented on a change in pull request #517:
URL: https://github.com/apache/orc/pull/517#discussion_r453929349
##########
File path: c++/test/TestBloomFilter.cc
##########
@@ -152,9 +152,9 @@ namespace orc {
// test strings
bloomFilter.reset();
- const char * emptyStr = u8"";
- const char * enStr = u8"english";
- const char * cnStr = u8"中国字";
+ const char * emptyStr = "";
+ const char * enStr = "english";
+ const char * cnStr = "中国字";
Review comment:
Did you run all tests too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
