nikitamikhaylov commented on a change in pull request #517:
URL: https://github.com/apache/orc/pull/517#discussion_r454279531
##########
File path: c++/test/TestBloomFilter.cc
##########
@@ -152,9 +152,9 @@ namespace orc {
// test strings
bloomFilter.reset();
- const char * emptyStr = u8"";
- const char * enStr = u8"english";
- const char * cnStr = u8"中国字";
+ const char * emptyStr = "";
+ const char * enStr = "english";
+ const char * cnStr = "中国字";
Review comment:
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0482r3.html
https://docs.microsoft.com/en-us/cpp/cpp/string-and-character-literals-cpp?view=vs-2019
There was funny warning from clang `type of UTF-8 string literal will change
from array of const char to array of const char8_t in C++20`
And your CI said that everything is Ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
