dongjoon-hyun commented on a change in pull request #634:
URL: https://github.com/apache/orc/pull/634#discussion_r564171846



##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -231,11 +224,9 @@ protected RecordReaderImpl(ReaderImpl fileReader,
     if (options.getPreFilterColumnNames() != null) {
       for (String colName : options.getPreFilterColumnNames()) {
         int expandColId = findColumns(evolution, colName);
+        // If the column is not present in the file then this can be ignored 
from read.
         if (expandColId != -1) {
           filterColIds.add(expandColId);
-        } else {
-          throw new IllegalArgumentException("Filter could not find column 
with name: " +
-              colName + " on " + evolution.getReaderBaseSchema());

Review comment:
       Could you confirm that what is the new error message? I understand that 
the thrown exception is the same, `IllegalArgumentException`, but I'm not sure 
about the information on the error message. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to