dongjoon-hyun commented on a change in pull request #634:
URL: https://github.com/apache/orc/pull/634#discussion_r564214073



##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -104,17 +104,10 @@
    */
   static int findColumns(SchemaEvolution evolution,

Review comment:
       For this one, we hit many issues at Apache ORC 1.6.x due to the breaking 
API and behavior change.
   Although this is an implementation internal class, Hive and Spark's hive 
module assumes old behavior.
   So, if we need this change, I'd like to recommend to have a configuration to 
support both behavior.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to