pgaref commented on a change in pull request #634:
URL: https://github.com/apache/orc/pull/634#discussion_r564733567
##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -110,10 +111,9 @@ static int findColumns(SchemaEvolution evolution,
TypeDescription fileColumn = evolution.getFileType(readerColumn);
return fileColumn == null ? -1 : fileColumn.getId();
} catch (IllegalArgumentException e) {
- if (LOG.isDebugEnabled()){
- LOG.debug("{}", e.getMessage());
- }
- return -1;
+ throw new IllegalArgumentException("Filter could not find column with
name: " +
Review comment:
Looked like the indentation was off here (on my IDE at least) but just
realised it was just split in 2 lines instead of 3 -- ignore the comment please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
