pavibhai commented on a change in pull request #634:
URL: https://github.com/apache/orc/pull/634#discussion_r564668912
##########
File path:
java/mapreduce/src/test/org/apache/orc/mapred/TestOrcFileEvolution.java
##########
@@ -235,35 +235,37 @@ public void testListEvolution() {
@Test
public void testPreHive4243CheckEqual() {
// Expect success on equal schemas
- checkEvolution("struct<_col0:int,_col1:string>",
+ checkEvolutionPosn("struct<_col0:int,_col1:string>",
"struct<_col0:int,_col1:string>",
struct(1, "foo"),
- struct(1, "foo", null), false, addSarg, false);
+ struct(1, "foo", null),
+ false, addSarg, false);
}
@Test
public void testPreHive4243Check() {
// Expect exception on strict compatibility check
thrown.expectMessage("HIVE-4243");
- checkEvolution("struct<_col0:int,_col1:string>",
+ checkEvolutionPosn("struct<_col0:int,_col1:string>",
"struct<_col0:int,_col1:string,_col2:double>",
struct(1, "foo"),
struct(1, "foo", null), false, addSarg, false);
}
@Test
public void testPreHive4243AddColumn() {
- checkEvolution("struct<_col0:int,_col1:string>",
+ checkEvolutionPosn("struct<_col0:int,_col1:string>",
"struct<_col0:int,_col1:string,_col2:double>",
struct(1, "foo"),
- struct(1, "foo", null), true, addSarg, false);
+ struct(1, "foo", null),
+ true, addSarg, false);
Review comment:
Done
##########
File path:
java/mapreduce/src/test/org/apache/orc/mapred/TestOrcFileEvolution.java
##########
@@ -235,35 +235,37 @@ public void testListEvolution() {
@Test
public void testPreHive4243CheckEqual() {
// Expect success on equal schemas
- checkEvolution("struct<_col0:int,_col1:string>",
+ checkEvolutionPosn("struct<_col0:int,_col1:string>",
"struct<_col0:int,_col1:string>",
struct(1, "foo"),
- struct(1, "foo", null), false, addSarg, false);
+ struct(1, "foo", null),
+ false, addSarg, false);
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
