kbendick commented on a change in pull request #754:
URL: https://github.com/apache/orc/pull/754#discussion_r676339263
##########
File path: java/core/src/java/org/apache/orc/impl/StringHashTableDictionary.java
##########
@@ -120,6 +122,11 @@ public void getText(Text result, int positionInKeyOffset) {
DictionaryUtils.getTextInternal(result, positionInKeyOffset,
this.keyOffsets, this.byteArray);
}
+ @Override
+ public ByteBuffer getText(int positionInKeyOffset) {
+ return DictionaryUtils.getTextInternal(positionInKeyOffset,
this.keyOffsets, this.byteArray);
+ }
Review comment:
Is it safe to be exporting this ByteBuffer? If it is reused /
overwritten in some way, will that affect any of the existing code.
Specifically, I'm wondering about the now returned `ByteBuffer` from
`setByteBuffer`, as the data can be returned without any copying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
