belugabehr commented on a change in pull request #754:
URL: https://github.com/apache/orc/pull/754#discussion_r697049931
##########
File path: java/core/src/java/org/apache/orc/impl/DictionaryUtils.java
##########
@@ -46,6 +47,18 @@ public static void getTextInternal(Text result, int position,
byteArray.setText(result, offset, length);
}
+ public static ByteBuffer getTextInternal(int position, DynamicIntArray
keyOffsets,
Review comment:
I think overloading a method with different return types is more proper
here. (I think we should keep as is).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
