pavibhai commented on a change in pull request #716:
URL: https://github.com/apache/orc/pull/716#discussion_r684529660



##########
File path: java/core/pom.xml
##########
@@ -37,6 +37,11 @@
       <groupId>org.apache.orc</groupId>
       <artifactId>orc-shims</artifactId>
     </dependency>
+    <dependency>

Review comment:
       I agree that generation is not having a lot of value given the 
separation of LeafFilter which also accounts for NOT operations now.
   
   I have removed this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to