pavibhai commented on pull request #716: URL: https://github.com/apache/orc/pull/716#issuecomment-894547303
@omalley Thanks for taking a detailed look into this. I have taken the branch you shared and did the following on top of the same. You will find separate commit for these changes. * Added the filter tests * Removed selIn as a parameter for the filter * Addressed review comments from Owen * Switched to compactExpression on the SearchArgument * Nested the filter classes in core * Removed JUnit dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
