guiyanakuang commented on a change in pull request #941:
URL: https://github.com/apache/orc/pull/941#discussion_r736180818



##########
File path: java/tools/src/java/org/apache/orc/tools/FileDump.java
##########
@@ -583,8 +602,10 @@ private static void recoverFile(final Path corruptPath, 
final FileSystem fs,
 
       // Move side file to backup path
       Path sideFilePath = OrcAcidUtils.getSideFile(corruptPath);
-      Path backupSideFilePath = new Path(backupDataPath.getParent(), 
sideFilePath.getName());
-      moveFiles(fs, sideFilePath, backupSideFilePath);
+      if (fs.exists(sideFilePath)) {

Review comment:
       I understand that this repair tool is geared towards this specific case, 
it assumes that `SideFile` must exist. The judgment I added for compatibility 
testing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to