dongjoon-hyun commented on a change in pull request #941:
URL: https://github.com/apache/orc/pull/941#discussion_r736182175
##########
File path: java/tools/src/java/org/apache/orc/tools/FileDump.java
##########
@@ -583,8 +602,10 @@ private static void recoverFile(final Path corruptPath,
final FileSystem fs,
// Move side file to backup path
Path sideFilePath = OrcAcidUtils.getSideFile(corruptPath);
- Path backupSideFilePath = new Path(backupDataPath.getParent(),
sideFilePath.getName());
- moveFiles(fs, sideFilePath, backupSideFilePath);
+ if (fs.exists(sideFilePath)) {
Review comment:
I'm okay with this `fs.exists` checking. However, this should go first
before this `OrcFileMAGIC` PR if you need this patch for your unit test. Please
make a separate PR (without a test case). I can merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
