guiyanakuang opened a new pull request #952:
URL: https://github.com/apache/orc/pull/952
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g.,
`ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of
describing the problem.
3. Make PR title and description complete because these will be the
permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce
the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
This pr is aimed at making ORC Writer support write thed selected vector.
Added InternalVectorizedRowBatch and InternalColumnVector classes to
encapsulate and replace VectorizedRowBatc and ColumnVector.
WholeVectorizedRowBatch/WholeColumnVector represents a batch/vector that
does not use selected.
SelectedVectorizedRowBatch/SelectedColumnVector represents a batch/vector
that does use selected.
During the write process we can use the same interface (`public int
getValueOffset(int offset) `) to get the offsets, making the changes minimal
and not doing anything redundant.
When writing to the encrypted column, a copy of the Selected Vector is made
without modifying the maskData interface, resulting in an unused Selected
Vector. Afterwards, the processing is the same as before.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Currently the ORC writer doesn't support the selected vector. This could
cause clients that expect it to be supported to get trash rows in the output.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Add UT TestSelectedVector.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
