guiyanakuang commented on a change in pull request #952: URL: https://github.com/apache/orc/pull/952#discussion_r778754272
########## File path: java/core/src/java/org/apache/orc/impl/SelectedColumnVector.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.orc.impl; + +import org.apache.hadoop.hive.ql.exec.vector.ColumnVector; + +import java.util.function.Function; + +public class SelectedColumnVector extends InternalColumnVector { + + private final int[] selected; + + public SelectedColumnVector(ColumnVector columnVector, int[] selected) { + super(columnVector); + this.selected = selected; + } + + @Override + public void ensureSize(int size, boolean preserveData) { + throw new UnsupportedOperationException( + "The ensureSize operation is not supported for SelectedColumnVector"); + } + + @Override + public boolean isNull(int offset) { + return columnVector.isNull[getValueOffset(offset)]; + } + + @Override + public int getValueOffset(int offset) { + return selected[offset]; Review comment: @wgtmac I am very sorry, I missed the message so late to reply The reason is that I can very easily construct the InternalColumnVector from vectorizedRowBatch, selected is actually an array passed in by vectorizedRowBatch, so there is no need to provide additional space to store selection information. SelectedVectorizedRowBatch.java ```java @Override public InternalColumnVector cols(int col) { return new SelectedColumnVector(vectorizedRowBatch.cols[col], vectorizedRowBatch.getSelected()); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
