guiyanakuang commented on a change in pull request #992:
URL: https://github.com/apache/orc/pull/992#discussion_r779992239
##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -462,8 +482,31 @@ public long getNext() {
this(predicate, null, null, hasNulls, false, false);
}
+ ValueRange(PredicateLeaf predicate, boolean hasNulls, boolean hasValue,
boolean comparable) {
+ this(predicate, null, null, hasNulls, false, false, hasValue,
comparable);
+ }
+
boolean hasValues() {
- return lower != null;
+ return hasValue;
+ }
+
+ /**
+ * This method is used separately when the hasValue is true
+ * Whether min or max is provided for comparison
+ * @return is it comparable
+ */
+ boolean comparable() {
+ return comparable;
Review comment:
How about this, return the expected value at all times
```java
/**
* Whether min or max is provided for comparison
* @return is it comparable
*/
boolean comparable() {
return hasValue && comparable;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
