dongjoon-hyun commented on a change in pull request #992:
URL: https://github.com/apache/orc/pull/992#discussion_r780725316
##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -575,7 +618,7 @@ static ValueRange getValueRange(ColumnStatistics index,
Boolean max = stats.getTrueCount() != 0;
return new ValueRange<>(predicate, min, max, stats.hasNull());
} else {
- return new ValueRange(predicate, null, null, true);
+ return new ValueRange(predicate, index.hasNull(), true, false);
Review comment:
This change looks a little misleading. Could you use the full
constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
