stiga-huang commented on a change in pull request #1044:
URL: https://github.com/apache/orc/pull/1044#discussion_r807465543
##########
File path: tools/src/CSVFileImport.cc
##########
@@ -420,13 +421,13 @@ int main(int argc, char* argv[]) {
case orc::STRING:
case orc::CHAR:
case orc::VARCHAR:
- case orc::BINARY:
+ case orc::BINARY:
+ bufferList.emplace_back(*orc::getDefaultPool(), 4 * 1024 * 1024);
Review comment:
Maybe we can reduce the buffer size to 1 * 1024 * 1024 now since it's
used per column.
We use 1MB buffer size in column writers:
https://github.com/apache/orc/blob/6f4481565761400587c7a266ca4c0a4244c0aa34/c%2B%2B/src/ColumnWriter.cc#L49-L62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
