stiga-huang commented on a change in pull request #1044:
URL: https://github.com/apache/orc/pull/1044#discussion_r807564435
##########
File path: tools/test/TestCSVFileImport.cc
##########
@@ -90,3 +90,27 @@ TEST (TestCSVFileImport, testTimezoneOption) {
EXPECT_EQ("", error);
}
}
+
+TEST (TestCSVFileImport, testLongBinary) {
+ // create an ORC file from importing the CSV file
+ const std::string pgm1 = findProgram("tools/src/csv-import");
+ const std::string csvFile =
findExample("TestCSVFileImport.testLongBinary.csv");
Review comment:
I think this test does not reveal the bug. We need a test that would
fail without the fix. So I think we need a csv file with strings larger than
4MB. It'd be better to create the csv file in the test instead of importing it
staticly in this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
