stiga-huang commented on a change in pull request #1062:
URL: https://github.com/apache/orc/pull/1062#discussion_r825870226



##########
File path: c++/src/Common.cc
##########
@@ -131,8 +131,11 @@ namespace orc {
   }
 
   std::string FileVersion::toString() const {
+    if (majorVersion == 1 && minorVersion == 9999) {
+      return "UNSTABLE-PRE-2.0";

Review comment:
       I think yes, but it'd be better to use RLEv3 since the values might have 
more tailing zeros than what we observed in 
https://github.com/apache/orc/pull/257#issuecomment-385100087




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to