stiga-huang commented on a change in pull request #1062:
URL: https://github.com/apache/orc/pull/1062#discussion_r825886667



##########
File path: c++/src/Reader.cc
##########
@@ -1389,6 +1389,13 @@ namespace orc {
       contents->footer = REDUNDANT_MOVE(readFooter(stream.get(), buffer.get(),
         footerOffset, *contents->postscript,  *contents->pool));
     }
+    if (contents->postscript->version_size() != 2) {
+      contents->fileVersion = std::unique_ptr<FileVersion>(new FileVersion(0, 
11));

Review comment:
       Yes. BTW, I refactored the codes to just keep an `isDecimalAsLong` flag 
in `FileContents` so this can be simpler.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to