sunriseLe commented on a change in pull request #385:
URL: https://github.com/apache/orc/pull/385#discussion_r835752858
##########
File path: proto/orc_proto.proto
##########
@@ -142,12 +149,35 @@ message ColumnEncoding {
optional uint32 bloomEncoding = 3;
}
+message StripeEncryptionVariant {
+ repeated Stream streams = 1;
+ repeated ColumnEncoding encoding = 2;
+}
+
+// each stripe looks like:
+// index streams
+// unencrypted
+// variant 1..N
+// data streams
+// unencrypted
+// variant 1..N
+// footer
+
message StripeFooter {
repeated Stream streams = 1;
repeated ColumnEncoding columns = 2;
optional string writerTimezone = 3;
+ // one for each column encryption variant
+ repeated StripeEncryptionVariant encryption = 4;
}
+// the file tail looks like:
+// encrypted stripe statistics: ColumnStripeStatistics (order by variant)
+// stripe statistics: Metadata
+// footer: Footer
Review comment:
> The encrypted file statistics are serialized directly into the
EncryptionVariant.fileStatistics.
When will EncryptionVarian.fileStatistics be not empty？ Or where is the
encryption variant for file statistics stored？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
