sunriseLe commented on a change in pull request #385:
URL: https://github.com/apache/orc/pull/385#discussion_r835750487
##########
File path: proto/orc_proto.proto
##########
@@ -120,6 +120,13 @@ message Stream {
ROW_INDEX = 6;
BLOOM_FILTER = 7;
BLOOM_FILTER_UTF8 = 8;
+ // Allocate space for the encrypted stuff
+ ENCRYPTED_INDEX = 9;
+ ENCRYPTED_DATA = 10;
+
+ // statistics streams
+ STRIPE_STATISTICS = 100;
+ FILE_STATISTICS = 101;
Review comment:
Do file statistics mean column statistics in file level？If so, file
statistics have already existed in the Footer.statistics .
For entrypted column, column statistcs will be compressed, encrypted. To
initial IV, you introduced a new steam kind FILE_STATISTICS？
> Encrypted stripe statistics will always be streams
Where will Encrypted stripe statistics store? Before MetaData?
Because you said:
```
// the file tail looks like:
// encrypted stripe statistics: ColumnarStripeStatistics (order by variant)
// stripe statistics: Metadata
// footer: Footer
// postscript: PostScript
// psLen: byte
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
