[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1082: ORC-1147: Use isNaN instead of isFinite to determine the contain NaN values

[GitBox]

dongjoon-hyun commented on code in PR #1082:
URL: https://github.com/apache/orc/pull/1082#discussion_r843447685


##########
java/core/src/test/org/apache/orc/TestVectorOrcFile.java:
##########
@@ -4153,6 +4153,96 @@ public void testPredicatePushdownWithNan() throws 
Exception {
     assertEquals(0, batch.size);
   }
 
+  @ParameterizedTest
+  @MethodSource("data")
+  public void testPredicatePushdownWithSumOverflow(Version fileFormat) throws 
Exception {

Review Comment:
   Ah, this is incompatible with branch-1.6. Let me fix it, @guiyanakuang .
   - https://github.com/apache/orc/runs/5844990614?check_suite_focus=true



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org