[GitHub] [orc] guiyanakuang commented on a diff in pull request #1082: ORC-1147: Use isNaN instead of isFinite to determine the contain NaN values

Tue, 05 Apr 2022 21:50:14 -0700 


guiyanakuang commented on code in PR #1082:
URL: https://github.com/apache/orc/pull/1082#discussion_r843458885


##########
java/core/src/test/org/apache/orc/TestVectorOrcFile.java:
##########
@@ -4153,6 +4153,96 @@ public void testPredicatePushdownWithNan() throws 
Exception {
     assertEquals(0, batch.size);
   }
 
+  @ParameterizedTest
+  @MethodSource("data")
+  public void testPredicatePushdownWithSumOverflow(Version fileFormat) throws 
Exception {

Review Comment:
   Thanks for fixing this incompatibility. 😃



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to