dongjoon-hyun commented on code in PR #1072:
URL: https://github.com/apache/orc/pull/1072#discussion_r846573319
##########
java/core/src/java/org/apache/orc/OrcConf.java:
##########
@@ -194,6 +194,18 @@
ORC_MAX_DISK_RANGE_CHUNK_LIMIT("orc.max.disk.range.chunk.limit",
"hive.exec.orc.max.disk.range.chunk.limit",
Integer.MAX_VALUE - 1024, "When reading stripes >2GB, specify max limit
for the chunk size."),
+ ORC_MIN_DISK_SEEK_SIZE("orc.min.disk.seek.size",
+ "hive.exec.orc.min.disk.seek.size",
+ 0,
+ "When determining contiguous reads, gaps within this
size are "
+ + "read contiguously and not seeked. Default value of
zero disables this "
+ + "optimization"),
+ ORC_MIN_DISK_SEEK_SIZE_TOLERANCE("orc.min.disk.seek.size.tolerance",
+ "hive.exec.orc.min.disk.seek.size.tolerance", 0.00,
Review Comment:
Can we remove this Hive conf? Actually, Apache Hive has no future release
plan to use this, doesn't it? I'm a little reluctant to add a misleading Hive
configuration from Apache ORC side if there is no agreement from Apache Hive
community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
