dongjoon-hyun commented on code in PR #1072:
URL: https://github.com/apache/orc/pull/1072#discussion_r850654384
##########
java/core/src/java/org/apache/orc/impl/RecordReaderUtils.java:
##########
@@ -405,72 +410,31 @@ static void zeroCopyReadRanges(FSDataInputStream file,
}
}
- /**
- * Read the data from the file based on a list of ranges in a single read.
- * @param file the file to read from
- * @param first the first range to read
- * @param last the last range to read
- * @param allocateDirect should we use direct buffers
- */
- static void readRanges(FSDataInputStream file,
Review Comment:
Do you think we can keep this in some way, @pavibhai ? Although it's `impl`
package, we know that some downstream like Hive and Flink is using our
internals. If possible, we should not remove anything for safety.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
