pavibhai commented on code in PR #1072:
URL: https://github.com/apache/orc/pull/1072#discussion_r850864934
##########
java/core/src/java/org/apache/orc/impl/RecordReaderUtils.java:
##########
@@ -405,72 +410,31 @@ static void zeroCopyReadRanges(FSDataInputStream file,
}
}
- /**
- * Read the data from the file based on a list of ranges in a single read.
- * @param file the file to read from
- * @param first the first range to read
- * @param last the last range to read
- * @param allocateDirect should we use direct buffers
- */
- static void readRanges(FSDataInputStream file,
Review Comment:
I checked out hive@master, flink@master and I don't see any references to
this method.
I think it should be fine to remove this method. As you called out given
that it is in impl I think we should be ok cleaning up a method that is package
local.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
