pavibhai commented on code in PR #1072:
URL: https://github.com/apache/orc/pull/1072#discussion_r850877592
##########
java/core/src/java/org/apache/orc/impl/RecordReaderUtils.java:
##########
@@ -481,26 +445,40 @@ static BufferChunk findSingleRead(BufferChunk first) {
* @param zcr the zero copy shim
* @param list the disk ranges within the file to read
* @param doForceDirect allocate direct buffers
+ * @param minSeekSize the minimum gap to prefer seek vs read
+ * @param minSeekSizeTolerance allowed tolerance for extra bytes in memory
as a result of
+ * minSeekSize
*/
static void readDiskRanges(FSDataInputStream file,
Review Comment:
sure, made it private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
