stiga-huang commented on code in PR #1087:
URL: https://github.com/apache/orc/pull/1087#discussion_r854180338
##########
c++/src/sargs/SargsApplier.hh:
##########
@@ -60,10 +60,11 @@ namespace orc {
const std::map<uint32_t, BloomFilterIndex>&
bloomFilters);
/**
- * Return a vector of bool for each row group for their selection
- * in the last evaluation
+ * Return a vector of the next skipped row for each RowGroup. Each value
is the row id
+ * in stripe. 0 means the current RowGroup is entirely skipped.
+ * Only valid after invoking pickRowGroups().
*/
- const std::vector<bool>& getRowGroups() const { return mRowGroups; }
Review Comment:
I think all the public header files that our users can use are
https://github.com/apache/orc/tree/main/c%2B%2B/include/orc
So this is not a breaking change.
BTW, the current `vector<uint64_t>` result is a superset of the original
`vector<bool>` in the way that 0 values mean not selected and non-zero values
mean selected. If your downstream projects port the ORC codes directly and
depend on this method, you can simply change the usages in this way.
If this is still not good enough, we can choose the simpler fix proposed by
@wgtmac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
